[EV3] Implement LED brightness control via software PWM on PRU1 #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
PR has been updated to download a released PRU binary (which is no worse than what currently happens for U-boot). This is now ready for review. |
dlech
reviewed
Jul 15, 2025
Collaborator
Author
|
Updated based on feedback. Using the linker script incidentally means that overflowing the shared memory region will be caught. However, this PR doesn't yet migrate PRU0 to use it. |
dlech
reviewed
Jul 16, 2025
dlech
reviewed
Jul 16, 2025
| $(BUILD)/pru_ledpwm.bin: | ||
| $(ECHO) "Downloading pru_ledpwm.bin" | ||
| $(Q)mkdir -p $(dir $@) | ||
| $(Q)curl -sL -o $@ https://github.com/pybricks/pybricks-pru/releases/download/v0.0.1/pru_ledpwm.bin |
Member
There was a problem hiding this comment.
I would already call it v1.0.0. (I no longer believe in https://0ver.org/) 😆
Member
|
This one looks good to go. |
Member
|
Although I just noticed too late that none of the commits have a description beyond the subject. We don't want to make a habit of this and instead would like at least one sentence explaining why the change is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on pybricks/pybricks-pru#1 , and it needs to be modified to download the PRU binary rather than checking it into git (see related: pybricks/support#2262 ), but I am opening the PR for now as the rest of the code is ready.