[EV3] New USB driver, batch 1 #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Jul 16, 2025
Member
dlech
left a comment
dlech
left a comment
There was a problem hiding this comment.
This is pretty dense so I had to give up about half way through, but here a few comments anyway.
ArcaneNibble
force-pushed
the
usb
branch
3 times, most recently
from
441fb06 to
fa15ccb
Compare
Collaborator
Author
|
Rebased this to be totally up to date with the latest merges. Also uses |
dlech
reviewed
Jul 19, 2025
Merged
ArcaneNibble
force-pushed
the
usb
branch
6 times, most recently
from
8557289 to
bbc7de3
Compare
Collaborator
Author
|
I've just implemented all the requested changes. |
dlech
reviewed
Jul 23, 2025
Member
dlech
left a comment
dlech
left a comment
There was a problem hiding this comment.
I did some work on USB in the meantime, so I found a few more details that I missed before with better trained eyes.
And it would be nice if we could make the commit messages a bit more descriptive for our future selves.
Otherwise, this looks good to go.
The TI CDC-ACM serial port is to be replaced by the custom Pybricks protocol. For now, delete all of the existing code and stub out necessary functions.
Delete this library so that we do not accidentally use it. It is not license-compatible with the GPL.
These are the most basic steps needed for a USB peripheral to be detected. After this commit, hosts will notice a USB device, but the device will not function because none of the required USB requests are handled.
These data types are defined in Chapter 9 of the USB standard and consistute the "USB Device Framework".
After this commit, the brick will be able to enumerate as a USB device. There is no data transfer implemented, but requests mandated by the USB standard are implemented so that the device is fully detected.
This currently implements an echo test rather than hooking up command handlers. This scaffolding is required before implementing the Pybricks protocol.
Collaborator
Author
|
Done! |
Member
|
OK! Let's call it good enough and move on to the next one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is batch 1 of reimplementing the EV3 USB support using a bespoke USB stack.
It currently provides only standard USB descriptors. When data is sent to the EP1 OUT endpoint, it will be echoed back (with the value 1 added to each byte) on EP1 IN.
The next steps will involve refactoring out some of the shared WebUSB/Microsoft descriptor creation code as well as hooking this up to existing command handlers.