Skip to content

pbio/drv/usb: extend USB transmit timeout #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025
Merged

pbio/drv/usb: extend USB transmit timeout #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pbio/drv/usb/usb_ev3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,7 @@ static pbio_error_t pbdrv_usb_ev3_process_thread(pbio_os_state_t *state, void *c
prev_status_flags = ~0;
}
} else if (!was_transmitting && is_transmitting) {
pbio_os_timer_set(&tx_timeout_timer, 5);
pbio_os_timer_set(&tx_timeout_timer, 50);
Copy link
Member Author

@dlech dlech Aug 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... EV3 seems to need an even longer timeout. I wonder if this means there is something else blocking this from updating or if the app really is taking that long to service the IN endpoint.

}
was_transmitting = is_transmitting;

Expand Down
2 changes: 1 addition & 1 deletion lib/pbio/drv/usb/usb_stm32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ PROCESS_THREAD(pbdrv_usb_process, ev, data) {
if (transmitting) {
// If the FIFO isn't emptied quickly, then there probably isn't an
// app anymore. This timer is used to detect such a condition.
etimer_set(&transmit_timer, 5);
etimer_set(&transmit_timer, 50);
}
}

Expand Down