pybricks.tools: Fix crash when cross() args are wrong type. #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for catching this. If we're going to add a verbose error, we should probably say that arguments should be three dimensional vectors (3x1 or 1x3 Matrix), combining it with the existing check below. |
Add type checking to fix a crash if the arguments to `cross()` are not `Matrix` objects.
laurensvalk
force-pushed
the
fix-cross-crash
branch
from
c3795f0 to
3fba188
Compare
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add type checking to fix a crash if the arguments to
cross()are notMatrixobjects.