pbio/drv/button_gpio: Wait for release and delay on power down. #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurensvalk
force-pushed
the
power-button-debounce
branch
from
7d56fe8 to
503b524
Compare
laurensvalk
force-pushed
the
power-button-debounce
branch
from
503b524 to
b45b272
Compare
Member
|
I don't understand what this actually does and there is no explanation in the commit message. |
Member
Author
|
Hmm, this wasn't supposed to be merged yet. |
Member
|
Oops. 😄 |
Member
Author
|
But what it does is:
|
Member
|
Ah, makes sense now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted fix for pybricks/support#2176, but cannot reproduce locally.