Address a potential issue in the PybricksHubUSB.write_gatt_char method
#109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e0ng
force-pushed
the
fix-usb-disconnect-timeout
branch
2 times, most recently
from
b338722 to
11637be
Compare
…hod. Previously, there was a concern that this part of the code could get stuck if the USB hub disconnected or didn't send a response. Here's how I've addressed it: - I've added a 5-second timeout for waiting for a response from the hub. - I'm now also monitoring for a hub disconnection while waiting for the response. If the hub disconnects, a `RuntimeError` will occur. If the operation times out, an `asyncio.TimeoutError` will occur. I've also included some checks in `tests/connections/test_pybricks.py` to ensure this new behavior works as expected in both disconnection and timeout situations.
1e0ng
force-pushed
the
fix-usb-disconnect-timeout
branch
from
11637be to
d2699e2
Compare
dlech
reviewed
May 31, 2025
dlech
reviewed
May 31, 2025
| timeout=1.0, | ||
| ) | ||
| except asyncio.TimeoutError: | ||
| if self.connection_state_observable.value != ConnectionState.CONNECTED: |
Member
There was a problem hiding this comment.
If race_disconnect() doesn't work, I don't think this will either since there is nothing to asynchronously set the connection state.
Contributor
Author
There was a problem hiding this comment.
That's a good point. Since race_disconnect isn't working (I didn't know when I created this PR), probably not worth doing this change anymore. Let me know if you think otherwise. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was a concern that this part of the code could get stuck if the USB hub disconnected or didn't send a response.
Here's how I've addressed it:
If the hub disconnects, a
RuntimeErrorwill occur. If the operation times out, anasyncio.TimeoutErrorwill occur.I've also included some checks in
tests/connections/test_pybricks.pyto ensure this new behavior works as expected in both disconnection and timeout situations.