Skip to content

pybricksdev.connections.pybricks: Set callback before sending subscribe #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

pybricksdev.connections.pybricks: Set callback before sending subscribe #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pybricksdev/connections/pybricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,8 +947,8 @@ async def write_gatt_char(self, uuid: str, data, response: bool) -> None:
await self._send_message(bytes([PybricksUsbOutEpMessageType.COMMAND]) + data)

async def start_notify(self, uuid: str, callback: Callable) -> None:
await self._send_message(bytes([PybricksUsbOutEpMessageType.SUBSCRIBE, 1]))
self._notify_callbacks[uuid] = callback
await self._send_message(bytes([PybricksUsbOutEpMessageType.SUBSCRIBE, 1]))

async def _monitor_usb(self):
loop = asyncio.get_running_loop()
Expand Down