pybricksdev: use explicit text encoding for text files #119
+203
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
force-pushed
the
explicit-text-encoding
branch
from
d60553a to
17e7944
Compare
Ensure that text files are opened with UTF-8 encoding by default to avoid issues with different default encodings. This also requires updating some dependencies that also had issues with text encoding. PYTHONWARNDEFAULTENCODING is set for tests to try to catch any future issues with text encoding. And PYTHONDEVMODE is set for good measure.
Ensure opened file is closed before the test ends.
dlech
force-pushed
the
explicit-text-encoding
branch
2 times, most recently
from
4626d0b to
939d618
Compare
Move from poetry-specific [tool.poetry] table to the standard [project] table. This fixes warnings from `poetry check`. Link: https://packaging.python.org/en/latest/specifications/pyproject-toml/#declaring-project-metadata-the-project-table
dlech
force-pushed
the
explicit-text-encoding
branch
from
939d618 to
53676ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that text files are opened with UTF-8 encoding by default to avoid issues with different default encodings. This also requires updating some dependencies that also had issues with text encoding.
PYTHONWARNDEFAULTENCODING is set for tests to try to catch any future issues with text encoding. And PYTHONDEVMODE is set for good measure.