migrate concatkdf{hash,hmac} to rust #13790
Merged
+274
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Nov 3, 2025
reaperhulk
force-pushed
the
kdf-concat
branch
from
ccfe7a2 to
fff177b
Compare
alex
reviewed
Nov 3, 2025
src/rust/src/backend/kdf.rs
Outdated
| let salt_bytes = if let Some(s) = salt { | ||
| s | ||
| } else { | ||
| pyo3::types::PyBytes::new(py, &vec![0u8; block_size_val]).into() |
Member
There was a problem hiding this comment.
PyBytes::new_with() and then no initializer, saves an alloc
src/rust/src/backend/kdf.rs
Outdated
| )); | ||
| } | ||
|
|
||
| // Check for block_size (required for HMAC) |
Member
There was a problem hiding this comment.
I don't know what this comment means
alex
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.