-
Notifications
You must be signed in to change notification settings - Fork 254
replace tox with nox #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace tox with nox #862
Conversation
|
I did this because it makes supporting free-threaded python a little easier - tox outright refuses to install 3.13t right now. |
noxfile.py
Outdated
| session.install(".[tests]") | ||
| session.install("mypy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so this doesn't precisely match what we had before, why the change? (Also consolidate)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean doing session.install(".[tests]")? That's needed because there's no implicit testenv in nox, unless I'm missing something in the nox docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, that's right, I forgot things were implicitly installed in tox. And they inherent the test extra by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And they inherent the test extra by default?
Yup!
|
mypy issue should be fixed with a rebase now |
|
hmm, what's going on with the wheel builder... |
|
It looks like the wheel-builder workflow is firing because I touched I bet it has bitrot in the meantime... The |
|
Grumble. I guess there's a side quest for me to debug it. :-(
…On Fri, Apr 4, 2025 at 12:27 PM Nathan Goldbaum ***@***.***> wrote:
It looks like the wheel-builder workflow is firing because I touched
setup.cfg. Before my PR, it last ran three months ago:
https://github.com/pyca/pynacl/actions/workflows/wheel-builder.yml.
I bet it has bitrot in the meantime...
The wheel project had a release yesterday, maybe related. I guess a pip
release could have broken something too?
—
Reply to this email directly, view it on GitHub
<#862 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBBOZRCZVXHQHVFQZQ32X2XFPAVCNFSM6AAAAAB2KVVHK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGIZTEOJXGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: ngoldbaum]*ngoldbaum* left a comment (pyca/pynacl#862)
<#862 (comment)>
It looks like the wheel-builder workflow is firing because I touched
setup.cfg. Before my PR, it last ran three months ago:
https://github.com/pyca/pynacl/actions/workflows/wheel-builder.yml.
I bet it has bitrot in the meantime...
The wheel project had a release yesterday, maybe related. I guess a pip
release could have broken something too?
—
Reply to this email directly, view it on GitHub
<#862 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBBOZRCZVXHQHVFQZQ32X2XFPAVCNFSM6AAAAAB2KVVHK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGIZTEOJXGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Co-authored-by: Alex Gaynor <[email protected]>
In the vein of pyca/bcrypt#954
Also a couple small unrelated fixes:
3.13-devonsetup-pythonto just3.13.