Skip to content

Conversation

@ngoldbaum
Copy link
Contributor

In the vein of pyca/bcrypt#954

Also a couple small unrelated fixes:

  • moves some jobs from 3.13-dev on setup-python to just 3.13.
  • Fixes a copy/paste error in the linux coverage upload

@ngoldbaum
Copy link
Contributor Author

I did this because it makes supporting free-threaded python a little easier - tox outright refuses to install 3.13t right now.

noxfile.py Outdated
Comment on lines 73 to 74
session.install(".[tests]")
session.install("mypy")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so this doesn't precisely match what we had before, why the change? (Also consolidate)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean doing session.install(".[tests]")? That's needed because there's no implicit testenv in nox, unless I'm missing something in the nox docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that's right, I forgot things were implicitly installed in tox. And they inherent the test extra by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And they inherent the test extra by default?

Yup!

@alex
Copy link
Member

alex commented Apr 4, 2025

mypy issue should be fixed with a rebase now

@alex
Copy link
Member

alex commented Apr 4, 2025

hmm, what's going on with the wheel builder...

@ngoldbaum
Copy link
Contributor Author

It looks like the wheel-builder workflow is firing because I touched setup.cfg. Before my PR, it last ran three months ago: https://github.com/pyca/pynacl/actions/workflows/wheel-builder.yml.

I bet it has bitrot in the meantime...

The wheel project had a release yesterday, maybe related. I guess a pip release could have broken something too?

@alex
Copy link
Member

alex commented Apr 4, 2025 via email

@alex alex merged commit 5848022 into pyca:main Apr 4, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants