fix: PyNaCl bundled libsodium config for android#896
Closed
Conversation
Fixes PyNaCl wheel build failure on android hosts because Android/Bionic does not have these in it's libc.
Member
|
This file comes from the upstream libsodium and we do not modify it. You shoudl send this PR to them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes PyNaCl wheel build failure on android hosts because Android/Bionic does not have these in it's libc.
On Android/Bionic these functions are not provided by libc (explicit_bzero, memset_s,
memset_explicit). This commit forces the configure cache variables for those functions to "no"
when building for Android, ensuring the generated config headers will not
advertise availability and the bundled libsodium will use its internal secure‑wipe
implementation fixing the build.