Skip to content

Improve Geometry class #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
yguclu wants to merge 30 commits into
base: devel
Choose a base branch
from
Draft

Improve Geometry class #527

yguclu wants to merge 30 commits into from

Conversation

@yguclu
Copy link
Member

@yguclu yguclu commented Oct 7, 2025 •
edited
Loading

  • Add new factory class method from_file
  • Use __init__ method in all factory class methods (from_file, from_discrete_mapping, and from_topological_domain)
  • Discourage direct use of __init__ (factory class methods should be preferred)
  • Add mandatory pdim parameter (number of dimensions of physical domain) to __init__
  • Clean up and document (with docstrings) the factory class methods

yguclu and others added 28 commits September 18, 2025 15:27
@yguclu
Allow mpi_dims_mask with geometry file
461ae4e
unit test for mpi_dims_mask
1e46072
@yguclu
Update test_geometry.py
3376e31 
- Write 3D geometry in parallel without `mpi_dims_mask`
- Read 3D geometry in parallel with `mpi_dims_mask`
- Verify correct distribution of domain for any number of MPI processes
@yguclu
Update geometry.py
2704716 
Add parameter `mpi_dims_mask` to class method `from_discrete_mapping` and bound method `read`.
@yguclu
Update test_geometry.py
e1a13f8 
Use new variable for dictionary with number of cells for each patch.
new tests for class Geometry
51a32da 
test methods from_discrete_mapping and from_topological_domain with mpi_dims_mask
run only my tests
505db31
run only my tests
39c51a4
run only my tests
34e42e6
run only my tests
90553f9
run only my tests
243d2b1
run only my tests
9bfda59
fixed failing tests due to deleting file in parallel
f75df55
revert files
2a7bb4d
@alisa-kirkinskaia
Merge branch 'devel' into yguclu-fix-mpi_dims_mask
659831d
@yguclu
Avoid function check_decomposition in tests
e7b6bfb
@yguclu
Fix typo in test_geometry.py
f6afb54
@yguclu
Improve Geometry class:
81b1c6d 
- Add new constructor Geometry.from_file
- Remove `filename` from __init__ parameters
@yguclu
Update Geometry unit tests
e3c30db
@yguclu
Squashed commit of the following:
8716dcb 
commit ccbd6e3
Author: Yaman Güçlü <[email protected]>
Date:   Wed Oct 1 06:25:42 2025 +0200

    Allow `mpi_dims_mask` with geometry file (#526)

    Add the optional parameter `mpi_dims_mask` to the constructor of class
    `Geometry`, as well as its class methods `from_discrete_mapping` and
    `from_topological_domain`. Add unit tests to verify that the domain is
    correctly decomposed.

    ---------

    Co-authored-by: Alisa Kirkinskaia <[email protected]>
    Co-authored-by: Alisa Kirkinskaia <[email protected]>
@yguclu
Do not create __psydac__ directory in parallel
7111b8e
@yguclu
Use Geometry.from_file in discretize_domain
cc097a3
@yguclu
Use correct parameter name (periods) in MultiPatchDomainDecomposition…
cd925fb 
… constructor
@yguclu
Add mandatory parameter pdim to Geometry.__init__
f1b6bb1
@yguclu
Clean up Geometry.read()
2716065
@yguclu
Remove unused property is_parallel from Geometry
818be2a
@yguclu
Merge branch 'devel' into yguclu-improve-Geometry
31fbb37
@yguclu
Clean up module psydac.mapping.discrete_gallery:
cb8ccb5 
- Add function `get_available_mappings`
- Clean up function `discrete_mapping` and add docstring to it
@campospinto campospinto mentioned this pull request Oct 17, 2025
Merged
3 tasks
@yguclu yguclu mentioned this pull request Oct 17, 2025
Open
@yguclu yguclu added the CAD Geometric operations on NURBS, geometry files, etc... label Oct 21, 2025
@yguclu yguclu mentioned this pull request Nov 12, 2025
Draft
@yguclu yguclu added the Next Release Must be in next release label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CAD Geometric operations on NURBS, geometry files, etc... Next Release Must be in next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yguclu @alisa-kirkinskaia