Skip to content

fix(proposal): 404 error for co-speaker #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SivanYeh wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix(proposal): 404 error for co-speaker #1188

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e62e90
fix-table-style
SivanYeh Apr 14, 2024
8eb2728
feat-hide buttons
SivanYeh Apr 24, 2024
cd3d415
Revert "feat-hide buttons"
SivanYeh Apr 30, 2024
a018685
feat-add switch on editable in templates
SivanYeh Apr 30, 2024
913b26d
feat(cospeaker): add uneditable table and msg
SivanYeh May 8, 2024
6a6c2d5
feat(proposals/test)-add test for additional speaker
SivanYeh May 20, 2024
54bf911
feat(cospeaker): add test for co-speaker
SivanYeh Jul 29, 2024
5efb4b7
feat(cospeaker): remove notification
SivanYeh Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/templates/default/users/_includes/dashboard_cospeaking_proposal_table.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% load i18n %}

<table class="proposals-table table table-striped table-hover">
<table class="proposals-table table table-responsive">
<thead>
<tr>
<th class="proposal-title">{% trans 'Title' %}</th>
Expand Down Expand Up @@ -34,7 +34,7 @@
<td>{{ speaker_info.get_status_display }}</td>
<td>
<form method="post"
action="{% url 'additional_speaker_set_status' pk=speaker_info.pk %}">
action="{% url 'additional_speaker_set_status' pk=speaker_info.pk %}" hidden>
Copy link
Member

@mattwang44 mattwang44 Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這個 form 永遠都會被藏起來，這是我們想要的嗎？

Copy link
Collaborator Author

@SivanYeh SivanYeh Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

果然答案沒有這麼簡單. 我再摸摸.
方向上是做一個switch?

Copy link
Member

@mattwang44 mattwang44 Apr 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

根據 discord 討論的 method 1，現況是後端已經有 switch（也就是 registry 存的 f'{settings.CONFERENCE_DEFAULT_SLUG}.proposals.editable'），方向是讓前端能根據這個 switch 現在是開或關來控制下列其一（可能需要先討論要選擇哪個）：
a. 這個 form 上能夠調整共同講者狀態之按鈕的 disabled 與否
b. 這個 form 的顯示與否
c. 可能有其他做法？

{% csrf_token %}
{% if speaker_info.status != 'accepted' %}
<button type="submit" name="status" value="accepted"
Expand Down