build(node): upgrade to node v20.11.0 and related dependency#1195
build(node): upgrade to node v20.11.0 and related dependency#1195SivanYeh merged 3 commits intopycontw:masterfrom
Conversation
|
hmmm it should have worked on WSL. Which docker version do you use now? |
|
should also edit the version defined in |
Sure, I just notice the ci error too, I think I will wait #1194 merged and edit all node version at once. |
|
Hi @mattwang44, things getting weird now..., I checkout master branch to run |
I'm afraid that I do not have enough time to cope with this issue until next week. |
|
Hi @mattwang44 , I think I'm making the first step done upgrading the node packages, please have a review. |
And yes....., I totally forgot I did not cleanup all images, no wonder it always failed. |
|
有 conflict 記得先解掉歐~ |
68dae65 to
249df13
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 73.99% 73.99%
=======================================
Files 81 81
Lines 3057 3057
=======================================
Hits 2262 2262
Misses 795 795 ☔ View full report in Codecov by Sentry. |
| '{node_sass_bin} --include --output-style expanded {paths} ' | ||
| '--include-path="{node_modules}" "{infile}" "{outfile}" && ' | ||
| '{postcss_bin} --use "{node_modules}/autoprefixer" ' | ||
| '{postcss_bin} --use "{node_modules}/autoprefixer/lib/autoprefixer.js" ' |
|
@SivanYeh please help to merge/deploy this PR whenever you think it's good to go |
There're several collaborations going on the same platforms within two weeks. |
SivanYeh
left a comment
There was a problem hiding this comment.
LGTM! It worked well during these two weeks. I will merge it into master.
Thanks all!




Types of changes
Description
Related Issue
Ideal to resolve all Dependabot alerts