adding pre-commit with a linting workflow #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pydanny
requested changes
Oct 1, 2023
Owner
pydanny
left a comment
pydanny
left a comment
There was a problem hiding this comment.
@JanAdamiak, this is AWESOME! 💯
There's just one problem, the changing of the order in cookiecutter.json breaks the intended workflow and will also throw errors. Can you skip that file in the pre-commit process?
Thanks!
| @@ -1,13 +1,23 @@ | |||
| { | |||
| "full_name": "Daniel Roy Greenfeld", | |||
| "__gh_slug": "{{ cookiecutter.github_username }}/{{ cookiecutter.slug }}", | |||
Owner
There was a problem hiding this comment.
This is a bug which will cause Cookiecutter to behave erratically or throw an error. This is because the __gh_slug element requires earlier items.
pydanny
reviewed
Oct 1, 2023
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v4.4.0 | ||
| hooks: |
Owner
There was a problem hiding this comment.
Please add hook to exclude cookiecutter.json from the linting process.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds precommit to the project.
Also adds a linting workflow that uses precommit.
There's a lot of file diffs in this one, that got picked up by the precommit's changes.
Let me know if you are okay with those ruff settings and precommit hooks?
Also should I add a precommit file and settings for it to the generated project?
Setting this one as draft until @pydanny replies to the questions above.