Skip to content

fix setting resource on custom log processor #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

davidhewitt
Copy link
Contributor

Noticed this downstream.

Would be nice to be able to test it's wired up, I'll write a PR to OTEL SDK to support getting the resource from the in-memory exporters so we can check it's correct. That shouldn't need to block merge.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/config.rs 69.23% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@davidhewitt
Copy link
Contributor Author

Upstream PR to help test at open-telemetry/opentelemetry-rust#3070

Copy link
Member

@friendlymatthew friendlymatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I hope they merge the PR quickly!

@davidhewitt davidhewitt merged commit 7376cd1 into main Jul 16, 2025
7 checks passed
@davidhewitt davidhewitt deleted the dh/fix-log-resource branch July 16, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants