Make app field optional in Flask, Starlette and FastAPI instrumentations #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
df85e15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4b82e74.logfire-docs.pages.dev |
| Branch Preview URL: | https://kludex-feat-no-need-for-app.logfire-docs.pages.dev |
Kludex
commented
Jul 16, 2025
alexmojaki
requested changes
Jul 17, 2025
| **opentelemetry_kwargs, | ||
| ) | ||
| if app is None: | ||
| FastAPIInstrumentor().instrument( |
There was a problem hiding this comment.
If it seems too hard to also apply the other fastapi instrumentation, at least comment about it
There was a problem hiding this comment.
I don't have the app instance, how would I go about it to make the custom logic work?
There was a problem hiding this comment.
if request.app not in registry then check for a 'global' FastAPIInstrumentation next.
There was a problem hiding this comment.
You mean modifying the patch function below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexmojaki As I told you, this only works if instrumentation happens before import.