Skip to content

Add note about write_token permission in logfire projects commands #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Draft

Add note about write_token permission in logfire projects commands #1545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions logfire/_internal/cli/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def parse_list_projects(args: argparse.Namespace) -> None:

projects = client.get_user_projects()
if projects:
sys.stderr.write("List of the projects you have write access to (requires the 'write_token' permission):\n\n")
sys.stderr.write(
_pretty_table(
['Organization', 'Project'],
Expand Down
2 changes: 1 addition & 1 deletion logfire/_internal/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,7 +1482,7 @@ def use_existing_project(
[f'{index}. {item[0]}/{item[1]}' for index, item in project_choices.items()]
)
selected_project_key = Prompt.ask(
f'Please select one of the following projects by number:\n{project_choices_str}\n',
f"Please select one of the following projects by number (requires the 'write_token' permission):\n{project_choices_str}\n",
choices=list(project_choices.keys()),
default='1',
)
Expand Down
2 changes: 2 additions & 0 deletions tests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,8 @@ def test_projects_list(default_credentials: Path, capsys: pytest.CaptureFixture[
output = capsys.readouterr().err
assert output.splitlines() == snapshot(
[
"List of the projects you have write access to (requires the 'write_token' permission):",
'',
' Organization | Project',
'----------------|--------',
' test-org | test-pr',
Expand Down
Loading