Skip to content

Daily CI with unpinned deps #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Daily CI with unpinned deps #583

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
985bf35
test-deps
sydney-runkle Nov 12, 2024
8e72641
run on PRs
sydney-runkle Nov 12, 2024
4791ded
Merge branch 'main' into test-with-upgraded-deps
alexmojaki Nov 13, 2024
7d26743
Remove temp line
alexmojaki Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions .github/workflows/daily_deps_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: Daily CI Job

on:
schedule:
- cron: '0 12 * * *' # Daily at midnight UTC
pull_request: {} # temporary: run on PRs so we can test this workflow

# Can be triggered manually from the actions tab, if needed
workflow_dispatch:

jobs:
test:
name: test on Python ${{ matrix.python-version }} and pydantic ${{ matrix.pydantic-version }}
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
pydantic-version: ['main']
include:
- python-version: '3.12'
pydantic-version: '2.4'
- python-version: '3.12'
pydantic-version: '2.5'
- python-version: '3.12'
pydantic-version: '2.6'
- python-version: '3.12'
pydantic-version: '2.7'
- python-version: '3.12'
pydantic-version: '2.8'
- python-version: '3.12'
pydantic-version: '2.9'
Comment on lines +12 to +31
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we do this only with Pydantic?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want a matrix for other deps too but it doesn't need to be a first step. We're still using the latest version of everything.

I also think that having this full matrix here means that regular CI only needs 2.4 and the latest release (pinned) and anything else needed for coverage (eventually v1 when some form of that works) so that it can run quickly and cheaply. Not a blocker though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmojaki,

Wouldn't it make sense to just test 2.4 and main on the daily CI, and leave all of these for the PR tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the daily CI is a good place to put things that take longer that we don't want to wait for to merge a PR.

env:
PYTHON: ${{ matrix.python-version }}
steps:
- uses: actions/checkout@v4

- name: Ensure requests to production domains fail
if: runner.os == 'Linux'
run: |
echo "203.0.113.0 logfire.dev" | sudo tee -a /etc/hosts
echo "203.0.113.0 logfire-api.pydantic.dev" | sudo tee -a /etc/hosts
echo "203.0.113.0 logfire.pydantic.dev" | sudo tee -a /etc/hosts

- name: Install uv
uses: astral-sh/setup-uv@v3
with:
version: "0.4.30"
enable-cache: true

# upgrade deps to the latest versions for this daily test
- run: uv sync --python ${{ matrix.python-version }} --upgrade

- name: Install pydantic ${{ matrix.pydantic-version }}
if: matrix.pydantic-version != 'main'
# installs the most recent patch on the minor version's track, ex 2.6.0 -> 2.6.4
run: uv pip install 'pydantic==${{ matrix.pydantic-version }}.*'

- run: uv run --no-sync pytest

- name: Notify on failure
if: failure()
run: echo "Tests failed. TODO - send notification..."
Loading