Skip to content

no in-place mutation for str and bytes#231

Merged
davidhewitt merged 1 commit intomainfrom
dh/immutable-str
Mar 3, 2026
Merged

no in-place mutation for str and bytes#231
davidhewitt merged 1 commit intomainfrom
dh/immutable-str

Conversation

@davidhewitt
Copy link
Collaborator

It doesn't make sense to mutate these types, they are immutable.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026

Merging this PR will degrade performance by 16.12%

❌ 1 regressed benchmark
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
loop_mod_13__monty 270.8 µs 322.8 µs -16.12%

Comparing dh/immutable-str (71bc46f) with main (fe9f22a)

Open in CodSpeed

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
crates/monty/src/heap.rs 0.00% 2 Missing ⚠️
crates/monty/src/types/list.rs 0.00% 2 Missing ⚠️
crates/monty/src/types/str.rs 60.00% 2 Missing ⚠️
crates/monty/src/bytecode/vm/binary.rs 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@davidhewitt davidhewitt merged commit 9a6f744 into main Mar 3, 2026
23 of 24 checks passed
@davidhewitt davidhewitt deleted the dh/immutable-str branch March 3, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant