try to pass vm around instead of (heap, interns)#234
Draft
davidhewitt wants to merge 5 commits intomainfrom
Draft
try to pass vm around instead of (heap, interns)#234davidhewitt wants to merge 5 commits intomainfrom
(heap, interns)#234davidhewitt wants to merge 5 commits intomainfrom
Conversation
Merging this PR will degrade performance by 13.15%
Performance Changes
Comparing |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP attempts to pass vm around more places instead of
heap, internsas separate pieces borrowed out of VM. This might help me with problems I'm facing in #207, but it's possible there are other ways to solve it.I think this refactoring would be necessary if monty ever supports the
classstatement, as the vm would be needed to run all the user code for magic methods such as__len__etc.I think it might also be completely reasonably to not do this and commit to not supporting user-defined classes. I can imagine that user-defined classes are extremely hard to support in the face of suspendable execution, as basically the entire interpreter could suspend at any point, so I think a lot of the code which is currently implemented as Rust would instead have to be rewritten as micro-ops which could be individually suspended. (That might ultimately pay out, but it seems risky / hard / potentially impossible for all code paths, such as when finding hash entry inside a dictionary.)