Add memory pre-checks to padding, replace and f-string operations#238
Merged
samuelcolvin merged 1 commit intomainfrom Mar 4, 2026
Merged
Add memory pre-checks to padding, replace and f-string operations#238samuelcolvin merged 1 commit intomainfrom
samuelcolvin merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
MRoci
force-pushed
the
nm/str-bytes-mem-checks
branch
from
70fccb3 to
71cad5c
Compare
Operations like f-string formatting, str.replace, str.ljust, str.center, str.rjust, str.zfill (and their bytes equivalents) allocated result strings (or Vecs) on the Rust heap before allocate_string/allocate_bytes could check against the ResourceTracker. This meant LimitedTracker's max_memory was ineffective for these operations. Adds check_replace_size pre-check and reuses check_repeat_size for padding to estimate result size before allocating and reject if it exceeds memory limits.
MRoci
force-pushed
the
nm/str-bytes-mem-checks
branch
from
71cad5c to
899ff10
Compare
Member
|
awesome, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operations like f-string formatting,
str.replace,str.ljust,str.center,str.rjust,str.zfill(and their bytes equivalents) allocated result strings (or Vecs) on the Rust heap beforeallocate_string/allocate_bytescould check against theResourceTracker.This meant
LimitedTracker's max_memory was ineffective for these operations.Adds
check_replace_sizepre-check and reusescheck_repeat_sizefor padding to estimate result size before allocating and reject if it exceeds memory limits.