Add on_complete callback to AG-UI functions to get access to AgentRunResult
#2429
+139
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
changed the title
on_complete callback to AG-UI functions to get access to AgentRunResult
DouweM
requested changes
Aug 6, 2025
ChuckJonas
force-pushed
the
#2398-ag-ui-on-complete-callback
branch
3 times, most recently
from
7100b97 to
a3ad970
Compare
ChuckJonas
force-pushed
the
#2398-ag-ui-on-complete-callback
branch
from
a3ad970 to
73af2b7
Compare
ChuckJonas
commented
Aug 7, 2025
| if _utils.is_async_callable(on_complete): | ||
| await on_complete(run) | ||
| else: | ||
| await _utils.run_in_executor(on_complete, run) |
There was a problem hiding this comment.
@DouweM not sure this is what you meant...
if _utils.is_async_callable(on_complete):
await on_complete(run)"None" is not awaitable
"None" is incompatible with protocol "Awaitable[_T_co@Awaitable]"
"await" is not present
And
else:
await _utils.run_in_executor(on_complete, run)Is saying it's unreachable.
There was a problem hiding this comment.
FWIW, I just ran in my project with both a sync and async callback and it seems to work as expected... Maybe just a type issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398