Add GPT-5 OpenAI model strings #2477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gpt-5-mini, gpt-5-nano and 2025-08-07 snapshots
zachmayer
changed the title
…el list for KnownModelName parity
…ixed and bare GPT-5 IDs in KnownModelName
zachmayer
force-pushed
the
feat/add-gpt5-model-ids
branch
from
6617a52 to
8b170ea
Compare
|
The new openai sdk (1.99.3) breaks some stuff, so I didn't bump it: https://pypi.org/project/openai/ |
|
Would it make sense to introduce the new |
yes |
Kludex
reviewed
Aug 8, 2025
Comment on lines
89
to
96
| # Include latest GPT-5 variants until the SDK enumerates them | ||
| Literal[ | ||
| 'gpt-5', | ||
| 'gpt-5-mini', | ||
| 'gpt-5-nano', | ||
| 'gpt-5-2025-08-07', | ||
| 'gpt-5-mini-2025-08-07', | ||
| 'gpt-5-nano-2025-08-07', |
There was a problem hiding this comment.
I think we just need to bump the minimum.
There was a problem hiding this comment.
@Kludex Bumping the min breaks a bunch of tests
Got it. |
|
Hi, Could you also add the chat model? |
|
Responding to PR feedbacK
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GPT-5 model IDs to KnownModelName