-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Example]: Multimodal RAG with LanceDB #2498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR Change SummaryAdded a new example for using LanceDB in a multimodal e-commerce context, enhancing the documentation for product cataloging and search functionalities.
Modified Files
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
I need some help with managing deps. It seems like lancedb is not being detected during test time even though I've added it to examples deps list. |
You need to add the dependency you need for the docs on the |
# pyright: reportMissingImports=false | ||
# pyright: reportInvalidTypeForm=false | ||
# pyright: reportUnknownVariableType=false | ||
# pyright: reportUnknownMemberType=false | ||
# pyright: reportUnknownArgumentType=false | ||
# pyright: reportUntypedBaseClass=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why so many?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be clear, we're happy to accept an example from you, but this is just a big middle finger to how we operate.
it's either saying:
- I don't care about any of your typing, linting, DX work
- or, we're special, we don't need to do this
Either lanceDB is typesafe, in which case remove these. or LanceDB is not type-safe in which case the example probably doesn't belong in our docs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these to figure out the deps part while fighting CI.. Will revert back
# pyright: reportMissingImports=false | ||
# pyright: reportInvalidTypeForm=false | ||
# pyright: reportUnknownVariableType=false | ||
# pyright: reportUnknownMemberType=false | ||
# pyright: reportUnknownArgumentType=false | ||
# pyright: reportUntypedBaseClass=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be clear, we're happy to accept an example from you, but this is just a big middle finger to how we operate.
it's either saying:
- I don't care about any of your typing, linting, DX work
- or, we're special, we don't need to do this
Either lanceDB is typesafe, in which case remove these. or LanceDB is not type-safe in which case the example probably doesn't belong in our docs!
Addressed specific feedbacks:
|
Multimodal RAG with LanceDB.
What this does:
find_products
tool that can:(e.g., "a cool t-shirt" from the "men's clothing" category under $20).
Install dependencies:
Set your Google API key (for the agent's text generation):
Usage:
First, build the product database from the live API