Handle function calls without text (#3) #2551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanabrooks
force-pushed
the
eb/handle-textless-function-calls
branch
from
9a487b8 to
cacaf7b
Compare
Collaborator
|
@ethanabrooks Can you show me the error you'd get without this? It's odd that Google could generate a model response with only tool calls and no text, that it then wouldn't accept when sent back on a subsequent request. |
DouweM
requested changes
Aug 14, 2025
| # If we only have function calls without text, add minimal text to satisfy Google API | ||
| if has_function_calls and not has_text_parts: | ||
| # Add a minimal text part to make the conversation valid for Google API | ||
| parts.append({'text': 'I have completed the function calls above.'}) |
Collaborator
There was a problem hiding this comment.
Does this need text or could be empty?
Collaborator
There was a problem hiding this comment.
Could we do this inside _content_model_response based on the ModelResponse's parts rather than parsing the returned ContentDict? We already iterate over all items there, so we can keep track of what we've seen.
ethanabrooks
force-pushed
the
eb/handle-textless-function-calls
branch
from
cacaf7b to
9facb04
Compare
Contributor
Author
|
In order to allow maintainer to push to branch, switching to this: #2557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.