Ensure that old ModelResponses stored in a DB can still be deserialized #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
DouweM
force-pushed
the
model-response-usage-deserialization
branch
from
a9657fc to
5f6999e
Compare
Contributor
|
Would you recommend migrating old 0.x ModelMessages we have in DB? |
Collaborator
Author
|
@nathan-gage With this change, it shouldn't be necessary, and I intend to keep message deserialization backward compatible for as long as possible. But if it's easy enough for you to do a migration, it would make you slightly less likely to run into issues if we were to accidentally break deserialization of older messages at some point. |
Contributor
|
@DouweM Ok, sounds good. We should be able to just round trip the serialization, right? |
Collaborator
Author
|
@nathan-gage Yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2789
Oversight from #2378, which went into v0.7.3 despite these being breaking changes.