-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feature: Minimal MCP client Resources support #3024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fennb
wants to merge
12
commits into
pydantic:main
Choose a base branch
from
fennb:feature/1783-minimal-mcp-resources-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+306
−11
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9fde764
Add initial list_resources() method to MCPServer.
fennb a7404a2
Add list_resource_templates() to MCPServer.
fennb ecea466
Workaround limitations with inline-snapshot & AnyUrl.
fennb 1886299
Add basic read_resource() to MCPServer.
fennb dfb54db
Update mcp client docs to add Resources section.
fennb f52bb71
Organize imports in doc examples.
fennb 232ff04
Update MCP resource example docs.
fennb 38675da
Merge branch 'pydantic:main' into feature/1783-minimal-mcp-resources-…
fennb 317416c
Create native Resource and ResourceTemplate types and update MCPServe…
fennb 67f9b07
Update MCPServer.read_resource() to decode/return native types.
fennb e6cb086
Add native MCP ResourceAnnotations type.
fennb b8424d8
Allow MCPServer.read_resource() to read resources by Resource.
fennb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my frustration, there is no support for annotations in
mcp.server.fastmcp.server.FastMCP.resource
: https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/server/fastmcp/server.py#L480This is what we use for testing in
mcp_server.py
, which means I couldn't actually write an integration test (at least using that pattern) to test it all end to end.Point me in the right direction if there's something else I should do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fennb That's annoying, so they support it on their client but not their server :/
@Kludex Any ideas?