Raise IncompleteToolCall when token limit is reached during generation of tool call
#3137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DouweM
requested changes
Oct 13, 2025
…ments, check if args actually are incomplete or not
erhuve
force-pushed
the
feat/ray/tool-exceeds-token-limit-error
branch
from
4ec19d6 to
537d6ce
Compare
DouweM
requested changes
Oct 14, 2025
DouweM
requested changes
Oct 16, 2025
| try: | ||
| tool_call.args_as_dict() | ||
| except Exception: | ||
| raise exceptions.ToolExceedsTokenLimitError( |
Collaborator
There was a problem hiding this comment.
I think this should be a subclass of UnexpectedModelBehavior for backward compatibility, and I suggest renaming it IncompleteToolCall
| # as the empty response and request will not create any items in the API payload, | ||
| # in the hope the model will return a non-empty response this time. | ||
| ctx.state.increment_retries(ctx.deps.max_result_retries) | ||
| max_tokens = (ctx.deps.model_settings or {}).get('max_tokens') if ctx.deps.model_settings else None |
Collaborator
There was a problem hiding this comment.
Can we pass in the entire model_settings object to clean these repeated sections up a bit?
…ol-exceeds-token-limit-error
…ckwards compat, simplify by passing in model settings instead of determining tokens on each call of increment_retries
DouweM
changed the title
IncompleteToolCall when token limit is reached during generation of tool call
Collaborator
|
@erhuve Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3118