Make it possible to use environment variables in mcp.json #3380
+305
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgillett
force-pushed
the
mcp-json-env-vars
branch
from
4c87ce3 to
d96f0f0
Compare
DouweM
requested changes
Nov 10, 2025
…de Code; compile a regex only once; use re.sub.
Author
|
@DouweM Thanks for the feedback. I have addressed all of it. Please let me know if there is more to do here, or if you are ready to remove the "awaiting author revision" label. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using environment variables is helpful to be able to check mcp.json into source control without embedding secrets, and to be able to vary configuration values dynamically.
In load_mcp_servers, expand any environment variables. Throw an exception if any variables don't have values.
Add tests and document the use of environment variables.