-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support tool and resource caching for MCP servers that support change notifications #3560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dsfaccini
wants to merge
12
commits into
pydantic:main
Choose a base branch
from
dsfaccini:mcp-list-tools-intelligently
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+359
−33
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8c90789
add tool and resource caching for mcp servers that support change not…
dsfaccini 57e94ff
apply review comments
dsfaccini 92aaa8b
Merge branch 'main' into mcp-list-tools-intelligently
dsfaccini fd9ddfb
reorder and add cahced prompts field
dsfaccini 86e204f
remove cahed prompts and replace mocked tests
dsfaccini 1d6041f
add live mcp tool change notification and narrow arg types
dsfaccini a715fc4
fix mcp image content b64decode bug - add support for audio
dsfaccini 970ca03
decode was right, fix test
dsfaccini c6ac978
cover the continuation of the loop branch
dsfaccini 75da1b7
cover the continuation of the loop branch
dsfaccini b97fa5e
narrow wording
dsfaccini df3568b
Merge branch 'main' into mcp-list-tools-intelligently
dsfaccini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,11 +91,19 @@ def add_msg( | |
| 'user', | ||
| mcp_types.ImageContent( | ||
| type='image', | ||
| data=base64.b64decode(chunk.data).decode(), | ||
| data=base64.b64encode(chunk.data).decode(), | ||
| mimeType=chunk.media_type, | ||
| ), | ||
| ) | ||
| elif isinstance(chunk, messages.BinaryContent) and chunk.is_audio: | ||
| add_msg( | ||
| 'user', | ||
| mcp_types.AudioContent( | ||
| type='audio', | ||
| data=base64.b64encode(chunk.data).decode(), | ||
|
||
| mimeType=chunk.media_type, | ||
| ), | ||
| ) | ||
| # TODO(Marcelo): Add support for audio content. | ||
| else: | ||
| raise NotImplementedError(f'Unsupported content type: {type(chunk)}') | ||
| else: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -235,6 +235,19 @@ async def use_elicitation(ctx: Context[ServerSession, None], question: str) -> s | |
| return f'User {result.action}ed the elicitation' | ||
|
|
||
|
|
||
| async def hidden_tool() -> str: | ||
| """A tool that is hidden by default.""" | ||
| return 'I was hidden!' | ||
|
|
||
|
|
||
| @mcp.tool() | ||
| async def enable_hidden_tool(ctx: Context[ServerSession, None]) -> str: | ||
| """Enable the hidden tool, triggering a ToolListChangedNotification.""" | ||
| mcp._tool_manager.add_tool(hidden_tool) # pyright: ignore[reportPrivateUsage] | ||
| await ctx.session.send_tool_list_changed() | ||
| return 'Hidden tool enabled' | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added a tool to enable the hidden tool |
||
|
|
||
|
|
||
| @mcp._mcp_server.set_logging_level() # pyright: ignore[reportPrivateUsage] | ||
| async def set_logging_level(level: str) -> None: | ||
| global log_level | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought
b64decodewas wrong here, because we generally useBinaryContent.datato store arbitrary bytes, not base64-encoded bytes. On closer look it's actually right, there are some tests settingBinaryContent.data = base64_bytes, for example, intest_anthropicandtest_mistral.So an idea: should we have a mechanism to avoid this confusion? Like
BinaryContent.datato be strictly non-base64 and instead having a property that returns it encoded?would help dumb humans (like me) and llms (currently equivalent to dumb humans) more easily navigagte and extend the functionality in the future.