Add gateway to Known Model Names #3593
Conversation
|
there's a flaky outlines test breaking CI :( |
| openai_names = [f'openai:{n}' for n in get_model_names(OpenAIModelName)] | ||
| bedrock_names = [f'bedrock:{n}' for n in get_model_names(BedrockModelName)] | ||
| deepseek_names = ['deepseek:deepseek-chat', 'deepseek:deepseek-reasoner'] | ||
| gateway_names = [ |
There was a problem hiding this comment.
I realize you couldn't see this comment in a private Slack channel, but I responded to Samuel (and he agreed):
Agreed, but if we add just a few per provider, people are definitely gonna ask us “but why not this other one?”, so maybe just include them all?
So we should NOT hard-code this, but dynamically build this based on the known model names of the providers that are known to work with gateway/{provider}
…/dsfaccini/pydantic-ai into add-gateway-to-known-model-names
tests/models/test_model_names.py
Outdated
| openai_names = [f'openai:{n}' for n in get_model_names(OpenAIModelName)] | ||
| bedrock_names = [f'bedrock:{n}' for n in get_model_names(BedrockModelName)] | ||
| deepseek_names = ['deepseek:deepseek-chat', 'deepseek:deepseek-reasoner'] | ||
| gateway_names = ( |
There was a problem hiding this comment.
Could we use the pydantic_ai.providers.gateway.UpstreamProvider type (possibly needs splitting up into 2 so that we don't include the APi types here), and then use those names as keys into a dict of things like {'openai': OpenAIModelName}? That way when we update it in the gateway file, this list will update too
There was a problem hiding this comment.
will check it out
2 participants
No description provided.