Skip to content

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Rust 1.78 targets Windows 10. Python 3.9 requires Windows 10.

Until we drop Python 3.8 support, we should build for Windows on Rust 1.77.

Related issue number

Fixes #1418

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Sep 23, 2024
Copy link

codspeed-hq bot commented Sep 23, 2024

CodSpeed Performance Report

Merging #1463 will not alter performance

Comparing dh/windows-1.77 (ad6478e) with main (bfccf09)

Summary

✅ 155 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@sydney-runkle sydney-runkle merged commit 4aa52a8 into main Sep 23, 2024
62 checks passed
@sydney-runkle sydney-runkle deleted the dh/windows-1.77 branch September 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Full Build cause CI to do a full build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to run on Windows 7. Please, remove support for Python v3.8. Because Python v3.8 still supports Windows 7

2 participants