-
Notifications
You must be signed in to change notification settings - Fork 312
Add invalid schema placeholder
#1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #1469 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the current error message if you try to create a SchemaValidator containing one of these? Should it be improved?
Good question. Definitely could be improved, though seems maybe ok for now? Traceback (most recent call last):
File "/Users/programming/pydantic_work/pydantic-core/test.py", line 3, in <module>
sv = SchemaValidator(core_schema.invalid_schema())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.SchemaError: Unknown schema type: "invalid" |
|
@davidhewitt, I can easily edit the error message in |
|
That placeholder seems reasonable. How about adding a |
Original-commit-hash: 0af18c4
Original-commit-link: pydantic/pydantic-core@0af18c4
Progress on pydantic/pydantic#10299
Sort of reminds me of #619, maybe we want to change this implementation to reflect some of those constraints?