Revert "feat: add 'millisecond' option to ser_json_timedelta"
#1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydney-runkle
changed the title
ser_json_timedeltaser_json_timedelta"
CodSpeed Performance ReportMerging #1503 will not alter performanceComparing Summary
|
davidhewitt
approved these changes
Oct 29, 2024
Contributor
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
As discussed, I think this is the right choice and look forward to the final design in 2.11 :)
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…ntic/pydantic-core#1503) Original-commit-hash: 8568136
davidhewitt
pushed a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning on adding support for this, but with a different API as mentioned here.