-
Notifications
You must be signed in to change notification settings - Fork 312
fix: implemented fallback if inline-snapshot is used with pypy #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 54 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
CodSpeed Performance ReportMerging #1533 will not alter performanceComparing Summary
|
|
please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed makes tests pass on PyPy, thanks!
| if sys.implementation.name == 'cpython': | ||
| from inline_snapshot import snapshot | ||
| else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to:
| if sys.implementation.name == 'cpython': | |
| from inline_snapshot import snapshot | |
| else: | |
| try: | |
| from inline_snapshot import snapshot | |
| except ImportError: |
? I mean, I've packaged inline-snapshot for Gentoo CPython already, but I suppose it may save others trouble for the time being.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got an idea. maybe we don't need this fix at all.
I can force inline-snapshot to run with --inline-snapshot=disable if something other then cpython is used. This would allow me to enable inline-snapshot again when I support it.
This would mean for you to package a inline-snapshot version for pypy which will not be able to create snapshots ... until I support it.
I think this would be better than to add a fix like this into every package which uses inline-snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure — but could you make it possible to run a subset of inline-snapshot's test suite that covers the available functionality on PyPy then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I will write some extra tests. But the disable logic is already tested.
Change Summary
Implemented fallback if inline-snapshot is used with pypy (or any other none cpython implementation of python).
I hope to support pypy in the future but I don't know how long this will take.
Related issue number
fix #1534
Checklist
pydantic-core(except for expected changes)Selected Reviewer: @davidhewitt