fix wasteful to_python() calls checking for undefined
#1580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1580 will improve performances by 49.85%Comparing Summary
Benchmarks breakdown
|
4 tasks
sydney-runkle
approved these changes
Dec 12, 2024
Contributor
|
Looks like we got some little 1-2% perf boosts! |
Contributor
Author
|
Haha check again 😂 |
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…antic-core#1580) Original-commit-hash: bd91c18
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Calling
.to_object()on JSON inputs is potentially expensive and they will NEVER bePydanticUndefined, so this is potentially a massive performance win on JSON validation...Related issue number
N/A
Checklist
pydantic-core(except for expected changes)