Update validate_smart function to better identify discriminated unions #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `validate_smart` function to better identify discriminated unions by using the class with the greatest number of matching fields, in addition to the greatest percentage of matching fields. * Modify the `validate_smart` function in `src/validators/union.rs` to include the number of matching fields in the comparison logic. * Add test cases in `tests/validators/test_union.py` to verify the updated `validate_smart` function correctly identifies the class with the greatest number of matching fields. * Test cases cover various scenarios, including cases with equal percentages but different numbers of matching fields. * Include test cases with classes that inherit from one another. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/pydantic/pydantic-core?shareId=XXXX-XXXX-XXXX-XXXX).
…umber of matching fields * Modify logic to compare the number of matching fields for each class * Fix mismatched types error by dereferencing the borrow
CodSpeed Performance ReportMerging #1612 will not alter performanceComparing Summary
|
|
This doesn't seem to work. I am trying again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
validate_smartfunction to better identify discriminated unions by using the class with the greatest number of matching fields, in addition to the greatest percentage of matching fields.validate_smartfunction insrc/validators/union.rsto include the number of matching fields in the comparison logic.tests/validators/test_union.pyto verify the updatedvalidate_smartfunction correctly identifies the class with the greatest number of matching fields.For more details, open the Copilot Workspace session.