Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Mar 31, 2025

Change Summary

Follow up on #1661.

Fixes pydantic/pydantic#11655.

(Also simplifies existing functions using get_item() and add more tests).

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos Viicos requested a review from davidhewitt March 31, 2025 12:06
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Performance Report

Merging #1676 will not alter performance

Comparing decimal-constraints (5bde9d4) with main (6c936de)

Summary

✅ 157 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a slight perf suggestion 👍

@Viicos Viicos enabled auto-merge (squash) April 1, 2025 14:19
@Viicos Viicos force-pushed the decimal-constraints branch from 75b0e1b to 7916664 Compare April 1, 2025 14:50
@Viicos Viicos force-pushed the decimal-constraints branch from 7916664 to 5bde9d4 Compare April 1, 2025 14:55
@Viicos Viicos merged commit 104d398 into main Apr 1, 2025
25 of 28 checks passed
@Viicos Viicos deleted the decimal-constraints branch April 1, 2025 15:01
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pydantic 2.11 breaks numeric constraints on timedelta fields

3 participants