drop serde-json preserve_order feature
#1724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #1724 will not alter performanceComparing Summary
|
Viicos
reviewed
May 28, 2025
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
Original-commit-hash: 238c1c7
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
Original-commit-link: pydantic/pydantic-core@238c1c7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Observed in pydantic/pydantic#7424 (comment), we currently use
preserve_orderfeature ofserde-json. This preserves ordering of values during parse.This should not be needed since we moved to
jiterfor parsing.Related issue number
N/A
Checklist
pydantic-core(except for expected changes)