Skip to content

Conversation

@Viicos
Copy link
Member

@Viicos Viicos commented Jun 11, 2025

Change Summary

Free-threaded on 3.13 is really slow, and has memory leaks no longer present in 3.14. I think it is not worth testing on 3.13 anymore.

Let's wait until the first 3.14 rc release before merging.

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 11, 2025

CodSpeed Performance Report

Merging #1738 will improve performances by 16.51%

Comparing stop-t-313 (68c8eac) with main (3415428)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_many_models_core_model 2.5 ms 2.2 ms +16.51%

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support this; also with PEP 779 just accepted the free-threaded build is "supported" in 3.14 unlike the experimental status of 3.13t

@Viicos
Copy link
Member Author

Viicos commented Jun 29, 2025

PEP 779 was added in 3.14a3, which we are now able to test with the latest uv update, so I'll merge now.

@Viicos Viicos merged commit b4fd517 into main Jun 29, 2025
58 checks passed
@Viicos Viicos deleted the stop-t-313 branch June 29, 2025 11:44
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants