Skip to content

Conversation

@ollz272
Copy link
Contributor

@ollz272 ollz272 commented Jun 16, 2025

…base

Change Summary

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@ollz272 ollz272 mentioned this pull request Jun 16, 2025
4 tasks
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/input/datetime.rs 0.00% 12 Missing ⚠️
src/validators/datetime.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

..Default::default()
},
&DateTimeConfig::builder()
.time_config(TimeConfig {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ Feel like we should use the builder here, but just left as is for now to make this a simple update

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 16, 2025

CodSpeed Performance Report

Merging #1741 will improve performances by 16.06%

Comparing ollz272:speedate-bump (86748f7) with main (3415428)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_many_models_core_model 2.5 ms 2.2 ms +16.06%

@ollz272 ollz272 marked this pull request as ready for review June 16, 2025 14:24
@ollz272 ollz272 closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant