Better document SerializationInfo
#1747
Conversation
CodSpeed Performance ReportMerging #1747 will not alter performanceComparing Summary
|
|
|
||
| @property | ||
| def mode(self) -> str: ... | ||
| def mode(self) -> Literal['python', 'json']: |
There was a problem hiding this comment.
Hi @Viicos,
In another place, Pydantic is less restrictive and allows the use of mode: Literal['json', 'python'] | str = 'python', so using only a Literal with two possibilities won't cause any problems?
On our end, MyPy throws errors because we use a custom mode for some models. Perhaps the other mode definitions (in pydantic) will evolve, and we'll have to find another way to use the "custom" mode. However, I currently don't know how to do that.
Best regards,
J.
There was a problem hiding this comment.
Hi @l00ptr, could you please provide more details on how you managed to integrate a custom mode in your Pydantic code? We currently support only two hardcoded modes, and I'd like to avoid "advertising" than custom modes may be supported while it isn't the case.
The existing Literal['json', 'python'] | str annotations were introduced a long time ago in pydantic/pydantic#4978, my best guess being that it wasn't clear if only two modes were to be supported.
…l_dump() (#1770)" This reverts commit d0dbb09. See #1747 (comment) for more details.
Original-commit-hash: 5e3bbb5
Original-commit-link: pydantic/pydantic-core@5e3bbb5
2 participants
Change Summary
Related issue number
Checklist
pydantic-core(except for expected changes)