Skip to content

Conversation

kinuax
Copy link
Contributor

@kinuax kinuax commented Jul 28, 2025

Change Summary

The from_exception_data docstring is updated to specify the proper class method, instead of static.

Related issue number

No issue number.

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 28, 2025

CodSpeed Performance Report

Merging #1768 will not alter performance

Comparing kinuax:clarify-docstring (2b20805) with main (550ee16)

Summary

✅ 157 untouched benchmarks

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, actually I think we can remove these two lines entirely, I don't think they are relevant for the end user.

@kinuax kinuax changed the title Clarify ValidationError.from_exception_data docstring Simplify ValidationError.from_exception_data docstring Jul 28, 2025
@kinuax
Copy link
Contributor Author

kinuax commented Jul 28, 2025

Thanks for reviewing, I have removed both lines.

@kinuax kinuax requested a review from Viicos July 28, 2025 11:40
@Viicos Viicos changed the title Simplify ValidationError.from_exception_data docstring Simplify ValidationError.from_exception_data() docstring Jul 28, 2025
@Viicos Viicos merged commit 04b296b into pydantic:main Jul 28, 2025
30 checks passed
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 20, 2025
davidhewitt pushed a commit to pydantic/pydantic that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants