fix default_factory which takes data on more types
#1822
Merged
+205
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
dh/fix-default-factory-error
branch
from
bc59bd9 to
c67199a
Compare
CodSpeed Performance ReportMerging #1822 will not alter performanceComparing Summary
|
Viicos
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Followup to #1623
This vastly extends the tests, to cover
dataclassandTypedDictas well as model, and also checks that these things behave properly in a union.For now I keep the state around, but I think in principle we could make these container types default-aware, make them the only place to legally set a default factory which takes data, and remove the state.
Related issue number
N/A
Checklist
pydantic-core(except for expected changes)