Update SemanticVersion #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it possible to use SemanticVersion to initialize models using the __init__ method without type errors.
This ensures that users of the JSON Schema also get their semantic versions validated. The pattern and the new test cases come from https://semver.org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive SemanticVersion from semver.Version
This change makes it possible to use SemanticVersion to initialize
models using the init method without type errors.
Add pattern to SemanticVersion's JSON Schema
This ensures that users of the JSON Schema also get their semantic
versions validated.
The pattern and the new test cases come from https://semver.org.