Added Time parsing to pendulum_dt #288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezz123
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Hello @Woody1193 can you please run pre-commit locally and also don't edit uv.lock manually you can use make rebuild-lockfiles
|
Sorry, I don't have the time to continue on this one. If someone else is willing to pick this up, I'd certainly appreciate it, but the project we were using this for is moving away from Python so we can't really justify additional effort right now. |
|
close this in favor of this #331 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
pendulum.Timeobject to the library. Note that this change was obnoxious to implement because pendulum does not parse time values uniformly. As an example, when callingpendulum.instanceon adatetime.timeobject, no time zone is inserted unless it is explicitly added to thedatetime.timeobject. However, ifpendulum.Time.instanceis called with adatetime.timeobject, then the timezone will be inferred to be UTC unless it is provided. Additionally, when parsing a string, timezones are ignored regardless of how the parsing is done.