fix (de-)serialization of pendulum durations #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezz123
approved these changes
Mar 6, 2025
|
Wow, that was fast. Thank you! Unfortunately, I was just about to add a commit as I spotted a mistake in the test. Obviously I need to use json serialization for testing, not python. Sorry for that. Let me open another PR for this real quick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the (de-)serialization of the pendulum Duration model.
The model now uses it's own custom serialization to ISO 8601, instead of delegating to the timedelta serialization which does not handle months. It further extends (de-)serialization of sub-seconds and negative durations.
fixes #295