Skip to content

Added test coverage for DomainStr validation including punycode and invalid inputs #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

Added test coverage for DomainStr validation including punycode and invalid inputs #330

merged 2 commits into from
Jul 31, 2025

Conversation

rhealakhotia
Copy link
Contributor

  1. Added parameterized tests for valid/invalid domain strings
  2. Included tests for punycode domains and non-string input types
  3. Ensured edge cases like trailing dots, missing TLDs, and long domains are covered

@rhealakhotia rhealakhotia mentioned this pull request Jul 31, 2025
Open
@yezz123 yezz123 merged commit 5ed9422 into pydantic:main Jul 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezz123 yezz123 yezz123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhealakhotia @yezz123