Skip to content

Fix relative path creation on Windows for fixtures #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

Fix relative path creation on Windows for fixtures #333

merged 1 commit into from
Aug 15, 2025

Conversation

denini08
Copy link
Contributor

@denini08 denini08 commented Aug 13, 2025 •
edited
Loading

Fix #332

Solution

Add drive compatibility check before using os.path.relpath():

  • If different drives on Windows → return absolute path
  • Otherwise → return relative path as before

yezz123
yezz123 approved these changes Aug 15, 2025
View reviewed changes
Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yezz123 yezz123 merged commit f106714 into pydantic:main Aug 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezz123 yezz123 yezz123 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueError when running some tests on Windows

2 participants

@denini08 @yezz123